-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut release 0.23.0-rc.0 #4625
Cut release 0.23.0-rc.0 #4625
Conversation
#4586 (comment) I suppose this needs fixing before the release :( |
Yup, that's a small blocker: #4586 (comment) |
7af94eb
to
600b723
Compare
rebased release branch on fixed main 💪🏽 Let's go! |
Do we need to mention #4421? With that PR we now pick up all of the APIs that a node exposes automatically, right? |
You are absolutely right I missed this. Just checked the code it does not matter indeed 💪🏽 |
Double checking now if this will work will old Rule/Metadata etc APIs? |
I think there is regression here - if someone points to old Ruler API (e.g Thanos Ruler) in |
I understand, but I think we can't assume that. One can roll querier without rolling other components. Adding test case and potential fix here: #4645 |
I might be wrong, all might be good thanks to |
Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
600b723
to
ee0c963
Compare
Addressed comment, @GiedriusS @hitanshu-mehta and confirmed all is good, no regression is there (spent ~2h on assuring that = worth it XD!). Thanks for amazing work (: |
* Cut release 0.23.0-rc.0 (#4625) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Updated version. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Cut 0.23.0-rc.1 and cherry picked 3 critical commits from main. (#4684) * Sidecar: Fix process external label on promethues v2.28+ use units.Bytes config type (#4657) * Sidecar: Fix process external label when promethues v2.28+ use units.Bytes config type (#4656) Signed-off-by: hanjm <hanjinming@outlook.com> * E2E: Upgrade prometheus image version Signed-off-by: hanjm <hanjinming@outlook.com> * upgrade Prometheus dependency version to v2.30.0 (#4669) * upgrade Prometheus dependency version to v2.30.0 Signed-off-by: Ben Ye <ben.ye@bytedance.com> * fix unit test Signed-off-by: Ben Ye <ben.ye@bytedance.com> # Conflicts: # go.mod # go.sum * Query: Fix (*exemplarsStream).receive/(*metricMetadataStream).receive/(*targetsStreamStream).receive infinite loop when target response Unimplemented error (#4676) (#4681) Signed-off-by: hanjm <hanjinming@outlook.com> * Cut 0.23.0-rc.1 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Jimmiehan <hanjinming@outlook.com> Co-authored-by: Ben Ye <yb532204897@gmail.com> * Cut 0.23.0 release. (#4697) * Endpointset: Do not use info client to obtain metadata (for now) (#4714) * Do not use info client to obtain metadata Signed-off-by: Matej Gera <matejgera@gmail.com> * Update CHANGELOG. Signed-off-by: Matej Gera <matejgera@gmail.com> * Comment out client.info usage Signed-off-by: Matej Gera <matejgera@gmail.com> * Fix lint error Signed-off-by: Matej Gera <matejgera@gmail.com> * Cutting 0.23.1 (#4718) Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Moved tutorials Thanos versions to 0.23.1 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> * Added volounteer for shepharding, fixed VERSION. Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Jimmiehan <hanjinming@outlook.com> Co-authored-by: Ben Ye <yb532204897@gmail.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com>
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com