Query: Put cache name on tracing spans #4696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With multiple caches, this change lets you see clearly which spans relate to which cache. Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
pracucci
reviewed
Sep 23, 2021
There was a problem hiding this comment.
Makes sense to me!
Could you fix the cache mock in tests, please?
pkg/store/cache/caching_bucket_test.go:227:22: cannot use cache (type *mockCache) as type cache.Cache in argument to cfg.CacheGetRange:
*mockCache does not implement cache.Cache (missing Name method)
Signed-off-by: Bryan Boreham <bjboreham@gmail.com>
metalmatze
approved these changes
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With multiple caches, this change lets you see clearly which spans relate to which cache.
Changes
Added a name member to caches, add this as a tag when tracing.
Verification
Left as an exercise.