-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.*: Removed limit for received message size through gRPC. #4708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Error log: observatorium-thanos-receive-default-9observatorium-thanos-receive-default-0 thanos-receive level=error ts=2021-09-24T18:13:03.444687849Z caller=handler.go:366 component=receive component=receive-handler err="10 errors: replicate write request for endpoint observatorium-thanos-receive-default-1.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-2.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6319597 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-1.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6319597 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-3.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6319597 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-7.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-8.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6197131 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-7.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6197131 vs. 4194304); store locally for endpoint observatorium-thanos-receive-default-9.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: conflict; replicate write request for endpoint observatorium-thanos-receive-default-0.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-2.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6119023 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-1.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6119023 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-0.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6119023 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-8.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-8.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6255490 vs. 4194304); store locally for endpoint observatorium-thanos-receive-default-9.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: conflict; forwarding request to endpoint observatorium-thanos-receive-default-0.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6255490 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-9.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-1.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6118562 vs. 4194304); store locally for endpoint observatorium-thanos-receive-default-9.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: conflict; forwarding request to endpoint observatorium-thanos-receive-default-0.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6118562 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-6.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-8.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5955344 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-7.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5955344 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-6.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5955344 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-2.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-2.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5867179 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-3.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5867179 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-4.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5867179 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-3.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-5.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6014110 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-3.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6014110 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-4.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6014110 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-4.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-5.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6064467 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-6.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6064467 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-4.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (6064467 vs. 4194304); replicate write request for endpoint observatorium-thanos-receive-default-5.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: quorum not reached: 3 errors: forwarding request to endpoint observatorium-thanos-receive-default-5.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5796760 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-7.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5796760 vs. 4194304); forwarding request to endpoint observatorium-thanos-receive-default-6.observatorium-thanos-receive-default.monitoring.svc.cluster.local:10901: rpc error: code = ResourceExhausted desc = grpc: received message larger than max (5796760 vs. 4194304)" msg="internal server error" Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
kakkoyun
approved these changes
Sep 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was quite common to hit receive limit using large remote write requests. In this PR I remove limits as we did not have them for send anyway. Probably proper way is to allow users to configure them via flags. Right now no use cases like this so let's consider configurability for the future.
Signed-off-by: Bartlomiej Plotka bwplotka@gmail.com