fix panic when warn is nil #4782
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
reviewed
Oct 15, 2021
pkg/api/api.go
Outdated
| @@ -242,6 +242,9 @@ func Respond(w http.ResponseWriter, data interface{}, warnings []error) { | |||
| Data: data, | |||
| } | |||
| for _, warn := range warnings { | |||
| if warn == nil { | |||
There was a problem hiding this comment.
But when it can be nil? Which endpoint are you calling to reproduce this?
There was a problem hiding this comment.
I think we need investigate the root cause too.
There was a problem hiding this comment.
Hi @GiedriusS @yeya24 @ianwoolf , I found the root cause. #4777 (comment) pr: #4805
|
A pr has been created to solve this problem #4797 |
ianwoolf
force-pushed
the
pr-fix-api-panic
branch
2 times, most recently
from
bf89673
to
de6822d
Compare
|
i add a unit test to test race. it will panic if without
|
Signed-off-by: ian woolf <btw515wolf2@gmail.com>
ianwoolf
force-pushed
the
pr-fix-api-panic
branch
from
de6822d
to
e02d1d4
Compare
|
I have merged a fix here: #4805 |
|
Thank you for your work, closing this as a fix has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ian woolf btw515wolf2@gmail.com
fix #4777