Make hyperlinks work #4821
Merged
Make hyperlinks work #4821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwplotka
reviewed
Nov 1, 2021
|
I think these links (plus any non-markdown resource links) are broken on the website but fine on GH. An automatic solution for this was already implemented in mdox but the config wasn't updated here. It just involves adding the line below to linkPrefixForNonMarkdownResources: "https://github.com/thanos-io/thanos/blob/main"Maybe it can be updated in this PR? Or I can raise new one? 🙂 |
|
Thanks @bwplotka @saswatamcode for your comments. Good to know we have automatic solution for this. Let me use this PR to update |
Signed-off-by: clyang82 <chuyang@redhat.com>
clyang82
force-pushed
the
correct_objectstore_link
branch
from
334033b to
f293bf0
Compare
|
/assign @saswatamcode |
saswatamcode
approved these changes
Nov 2, 2021
2 tasks
yeya24
approved these changes
Nov 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: clyang82 chuyang@redhat.com
Changes
Verification