Store: Make queryStats log with human-readable format.

[hanjm]

The queryStats log is very useful to debug query in thanos-store.
But currently the duration field is unexported so that fmt.Printf("%+v", stats) print a number for time.Duration.

Before:

level=debug msg="stats query processed" stats="&{blocksQueried:1 postingsTouched:102 postingsTouchedSizeSum:1122 postingsToFetch:0 postingsFetched:1 postingsFetchedSizeSum:404 postingsFetchCount:1 postingsFetchDurationSum:162905 cachedPostingsCompressions:1 cachedPostingsCompressionErrors:0 cachedPostingsOriginalSizeSum:404 cachedPostingsCompressedSizeSum:18 cachedPostingsCompressionTimeSum:29569 cachedPostingsDecompressions:101 cachedPostingsDecompressionErrors:0 cachedPostingsDecompressionTimeSum:65901 seriesTouched:100 seriesTouchedSizeSum:1229 seriesFetched:54 seriesFetchedSizeSum:67120 seriesFetchCount:1 seriesFetchDurationSum:247635 chunksTouched:100 chunksTouchedSizeSum:1236 chunksFetched:100 chunksFetchedSizeSum:17817 chunksFetchCount:1 chunksFetchDurationSum:135030 getAllDuration:1744138 mergedSeriesCount:100 mergedChunksCount:100 mergeDuration:106200}" err=null

After:

Logs

level=debug msg="stats query processed" request="max_time:99 matchers: matchers: matchers: " stats="&{blocksQueried:2 postingsTouched:203 postingsTouchedSizeSum:2812 postingsToFetch:0 postingsFetched:203 postingsFetchedSizeSum:4478 postingsFetchCount:2 PostingsFetchDurationSum:576.127µs cachedPostingsCompressions:203 cachedPostingsCompressionErrors:0 cachedPostingsOriginalSizeSum:2812 cachedPostingsCompressedSizeSum:1454 CachedPostingsCompressionTimeSum:358.132µs cachedPostingsDecompressions:0 cachedPostingsDecompressionErrors:0 CachedPostingsDecompressionTimeSum:0s seriesTouched:100 seriesTouchedSizeSum:1229 seriesFetched:100 seriesFetchedSizeSum:68592 seriesFetchCount:1 SeriesFetchDurationSum:353.677µs chunksTouched:100 chunksTouchedSizeSum:1236 chunksFetched:100 chunksFetchedSizeSum:17817 chunksFetchCount:1 ChunksFetchDurationSum:221.653µs GetAllDuration:4.764037ms mergedSeriesCount:100 mergedChunksCount:100 MergeDuration:127.72µs}" err=null

Signed-off-by: Jimmie Han hanjinming@outlook.com

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

1. Exporte time.Duration type field.
2. add request field to log.
3. change the xxsizeSum field type to units.Base2bytes

Verification

Unit test

[hanjm]

A bit more idea，Could i add a flag to only log duration logger than specific value? like thanos-query does.

[hanjm]

The second commit change the xxsizeSum field type to units.Base2bytes, which log human-readable format.

level=debug msg="stats query processed" request="max_time:99 matchers:<name:"foo" value:"bar" > matchers:<name:"b" value:"1" > matchers:<type:NEQ name:"i" > " stats="&{blocksQueried:1 postingsTouched:102 PostingsTouchedSizeSum:1KiB98B postingsToFetch:0 postingsFetched:1 PostingsFetchedSizeSum:404B postingsFetchCount:1 PostingsFetchDurationSum:81.635µs cachedPostingsCompressions:1 cachedPostingsCompressionErrors:0 CachedPostingsOriginalSizeSum:404B CachedPostingsCompressedSizeSum:18B CachedPostingsCompressionTimeSum:15.529µs cachedPostingsDecompressions:101 cachedPostingsDecompressionErrors:0 CachedPostingsDecompressionTimeSum:20.957µs seriesTouched:100 SeriesTouchedSizeSum:1KiB205B seriesFetched:54 SeriesFetchedSizeSum:65KiB560B seriesFetchCount:1 SeriesFetchDurationSum:115.953µs chunksTouched:100 ChunksTouchedSizeSum:1KiB212B chunksFetched:100 ChunksFetchedSizeSum:17KiB409B chunksFetchCount:1 ChunksFetchDurationSum:64.246µs GetAllDuration:823.856µs mergedSeriesCount:100 mergedChunksCount:100 MergeDuration:51.937µs}" err=null

[GiedriusS]

One nit - could you please see if it makes sense? This is a nice improvement. Please also rebase 💪

[hanjm]

Thank you. Let me rebase it.

[matej-g]

Looks good 🤘

[hanjm]

Rebase Done~ @GiedriusS