querier: Add validation for querier address flags #4897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
force-pushed
the
endpoint-check
branch
from
68dde86
to
9a5d3f7
Compare
GiedriusS
reviewed
Nov 24, 2021
| } | ||
|
|
||
| set[s] = struct{}{} |
There was a problem hiding this comment.
Maybe we can also call https://pkg.go.dev/net#ParseIP here to check scratch that, it is probably tricky to check whether we were given a hostname or if we were given an IP addresshostAndPort[0]?
GiedriusS
reviewed
Nov 25, 2021
There was a problem hiding this comment.
I was thinking that maybe instead of using Strings() on these flags, we could define a custom parser (https://github.com/alecthomas/kingpin#custom-parsers) that automatically calls validateAddrs? That way we wouldn't miss calling these functions on the provided values. What do you think? 🤔
|
This would be better! Let me try it out and push a commit. 🙂 |
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
|
I've changed this to custom kingpin parser which is defined in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR adds validation for querier address flags.
Adds the
validateAddrs()function which checks for duplicates, empty or invalid addresses provided using--endpoint,--store,--rule,--metadata,--exemplaror--targetflags.Fixes #4894.
Verification
Tested locally.