Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve auto downsampling query param docs #4913

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Improve auto downsampling query param docs #4913

merged 1 commit into from
Nov 29, 2021

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Nov 29, 2021

  • Include auto in the list of options.
  • Improve wording.
  • Add backticks around the values.

Signed-off-by: SuperQ superq@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@SuperQ
Improve auto downsampling query param docs
fbecf0d 
* Include `auto` in the list of options.
* Improve wording.
* Add backticks around the values.

Signed-off-by: SuperQ <superq@gmail.com>
squat
squat approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SuperQ

@squat squat enabled auto-merge (squash) November 29, 2021 18:07
@squat squat merged commit f496f90 into thanos-io:main Nov 29, 2021
@SuperQ SuperQ deleted the superq/max_source_resolution_auto branch November 29, 2021 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SuperQ @squat