Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add changelog about redis cache #4931

Merged
merged 3 commits into from
Dec 16, 2021
Merged

docs: add changelog about redis cache #4931

merged 3 commits into from
Dec 16, 2021

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Dec 8, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  1. docs: add changelog about redis cache.
  2. fix code review in Cache: support redis cache backend #4888.

Verification

@hanjm hanjm force-pushed the feature/store-redis-cache branch from c44deec to b8fba3f Compare December 11, 2021 13:11
@hanjm hanjm mentioned this pull request Dec 11, 2021
Merged
2 tasks
@hanjm hanjm force-pushed the feature/store-redis-cache branch from b8fba3f to 55d2748 Compare December 11, 2021 13:41
yeya24
yeya24 previously approved these changes Dec 11, 2021
View reviewed changes
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/queryfrontend/cache.go Outdated Show resolved Hide resolved
@hanjm hanjm force-pushed the feature/store-redis-cache branch from 55d2748 to cc4593c Compare December 14, 2021 13:00
@hanjm hanjm requested a review from yeya24 December 14, 2021 13:01
hanjm added 3 commits December 16, 2021 15:18
@hanjm
docs: add changelog about redis cache
f96b37b 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm
docs: fix comment
ff16a7a 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm
docs: fix typo
651489c 
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@hanjm hanjm force-pushed the feature/store-redis-cache branch from cc4593c to 651489c Compare December 16, 2021 07:18
@GiedriusS GiedriusS enabled auto-merge (squash) December 16, 2021 07:33
@GiedriusS GiedriusS merged commit d08da88 into thanos-io:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GiedriusS GiedriusS GiedriusS approved these changes

@yeya24 yeya24 Awaiting requested review from yeya24

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hanjm @GiedriusS @yeya24