Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add changelog about redis cache #4931

Merged
merged 3 commits into from
Dec 16, 2021

Conversation

hanjm
Copy link
Member

@hanjm hanjm commented Dec 8, 2021

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  1. docs: add changelog about redis cache.
  2. fix code review in Cache: support redis cache backend #4888.

Verification

yeya24
yeya24 previously approved these changes Dec 11, 2021
Copy link
Contributor

@yeya24 yeya24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pkg/queryfrontend/cache.go Outdated Show resolved Hide resolved
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
@GiedriusS GiedriusS enabled auto-merge (squash) December 16, 2021 07:33
@GiedriusS GiedriusS merged commit d08da88 into thanos-io:main Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants