Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade golang to 1.17 #4945

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Upgrade golang to 1.17 #4945

merged 2 commits into from
Dec 16, 2021

Conversation

clyang82
Copy link
Contributor

@clyang82 clyang82 commented Dec 13, 2021

Signed-off-by: clyang82 chuyang@redhat.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Golang 1.15 is now at end of life - https://endoflife.date/go

Verification

@clyang82 clyang82 force-pushed the update_golang branch 2 times, most recently from 34f26c6 to e8e77c1 Compare December 13, 2021 09:25
@clyang82 clyang82 changed the title Upgrade golang to 1.17 [WIP]Upgrade golang to 1.17 Dec 13, 2021
Signed-off-by: clyang82 <chuyang@redhat.com>
@clyang82 clyang82 changed the title [WIP]Upgrade golang to 1.17 Upgrade golang to 1.17 Dec 13, 2021
@saswatamcode
Copy link
Member

saswatamcode commented Dec 14, 2021

I think lint fails due to: fatih/faillint#24.

Edit: Raised PR to fix this: fatih/faillint#28

@saswatamcode
Copy link
Member

@clyang82 you can now pull the latest version of faillint as the fix has been merged with: bingo get github.com/fatih/faillint@v1.8.0 🙂

Signed-off-by: clyang82 <chuyang@redhat.com>
@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 16, 2021
@clyang82
Copy link
Contributor Author

@clyang82 you can now pull the latest version of faillint as the fix has been merged with: bingo get github.com/fatih/faillint@v1.8.0 🙂

Updated. Thanks @saswatamcode for your help.

Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx ❤️

@GiedriusS GiedriusS merged commit f527d26 into thanos-io:main Dec 16, 2021
@clyang82 clyang82 deleted the update_golang branch December 17, 2021 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants