store: fix label extending #4985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the appropriate function `labelpb.ExtendSortedLabels` to extend the labelset in `queryPrometheus` with external labels. It maintains the invariant that labelset is a sorted set of labels. Otherwise, random errors might occur with pushdown enabled: `Error executing query: vector cannot contain metrics with the same labelset` I have triggered this with a weird query `max_over_time(up[5m])` & with HA pairs. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
|
cc @fpetkovski |
fpetkovski
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the appropriate function
labelpb.ExtendSortedLabelsto extend thelabelset in
queryPrometheuswith external labels. It maintains theinvariant that labelset is a sorted set of labels. Otherwise, random
errors might occur with pushdown enabled:
Error executing query: vector cannot contain metrics with the same labelsetI have triggered this with a weird query
max_over_time(up[5m])& withHA pairs.
Signed-off-by: Giedrius Statkevičius giedrius.statkevicius@vinted.com