Increase indexheader_lazy_load_duration_seconds buckets #5005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In Cortex we've noticed that the 99th percentile computed on
indexheader_lazy_load_duration_seconds
is always capped to 5s even if the average can be way higher. Reason is that the largest histogram bucket is 5s but lazy loading can take way longer than that (mostly depending on index size and the disk speed).In this PR I proposes to add more buckets to the metric, to have a better estimation of 99th percentile on high durations.
Is it? Do you track such changes in CHANGELOG?
Verification
N/A