Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Website] Fixed footer items alignment #5019

Merged
merged 2 commits into from
Jan 4, 2022
Merged

[Website] Fixed footer items alignment #5019

merged 2 commits into from
Jan 4, 2022

Conversation

NikhilSharma03
Copy link
Contributor

@NikhilSharma03 NikhilSharma03 commented Jan 2, 2022 •
edited
Loading

Signed-off-by: Nikhil Sharma nikhilsharmamusic2000@gmail.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Fixed footer items alignment (for smaller devices)

Before Changes

Screenshot from 2022-01-02 16-52-59

After Changes

Screenshot from 2022-01-02 16-59-45

Verification

@NikhilSharma03
[Website] Fixed footer items alignment
e5533f1 
Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
wiardvanrij
wiardvanrij previously approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@wiardvanrij wiardvanrij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@NikhilSharma03
fixed tiny nit
44daba8 
Signed-off-by: Nikhil Sharma <nikhilsharmamusic2000@gmail.com>
kakkoyun
kakkoyun approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

squat
squat approved these changes Jan 4, 2022
View reviewed changes
Copy link
Member

@squat squat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks :)

@squat squat merged commit 6e865d5 into thanos-io:main Jan 4, 2022
@NikhilSharma03 NikhilSharma03 deleted the footer_alignment branch January 4, 2022 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@squat squat squat approved these changes

@kakkoyun kakkoyun kakkoyun approved these changes

@wiardvanrij wiardvanrij wiardvanrij left review comments

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NikhilSharma03 @kakkoyun @wiardvanrij @squat