Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/quick docs - only check docs that are changed for quick dev work #5028

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

wiardvanrij
Copy link
Member

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Added an extra Makefile option that only checks for .md files that are actually changed. Removing the need to iterate over the entire project (takes minutes!).

Verification

Locally tested.

Signed-off-by: Wiard van Rij <wiard@outlook.com>
Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great change. How about using it for CI as well?

@GiedriusS
Copy link
Member

This is a great change. How about using it for CI as well?

I don't think we can because we care about all links working. There is an unfortunate consequence that any PR may fail due to unrelated changes but I think it's better than to have essentially basically close to no link checking at all :/

@kakkoyun kakkoyun merged commit f2628ce into thanos-io:main Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants