cli: print usage before error when argument parsing causes an error #5034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This intends to improve error reporting in k8s. Before this change thanos would print the error, followed by the usage. The latter part would fill up a container status message (in say `kubectl describe`) with the usage, hiding the actual error. Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
|
I'm sure there is a better solution for this, I went with the smallest change to see what the maintainers think. |
GiedriusS
approved these changes
Jan 6, 2022
|
I think this makes sense and it's a nice usability improvement. 👍 |
|
Documentation check seems broken :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to improve error reporting in k8s. Before this change
thanos would print the error, followed by the usage. The latter part
would fill up a container status message (in say
kubectl describe)with the usage, hiding the actual error.
Signed-off-by: Jan Fajerski jfajersk@redhat.com
Changes
Verification