prober: Remove spam of changing probe status #5051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juozas Vainauskas <vainauskasjuozas@gmail.com>
Signed-off-by: Juozas Vainauskas <vainauskasjuozas@gmail.com>
yeya24
reviewed
Jan 10, 2022
GiedriusS
reviewed
Jan 10, 2022
pkg/prober/intrumentation.go
Outdated
| @@ -23,7 +24,8 @@ type InstrumentationProbe struct { | |||
| component component.Component | |||
| logger log.Logger | |||
|
|
|||
| status *prometheus.GaugeVec | |||
| status *prometheus.GaugeVec | |||
| formerStatus string | |||
There was a problem hiding this comment.
We need a lock here since Ready/NotReady could be called from multiple goroutines. Also, it's not really former, is it? It's the current status at the time of the function call thus it looks weird. I suggest being explicit here and renaming these two variables into statusMetric and statusString or something.
Signed-off-by: Juozas Vainauskas <vainauskasjuozas@gmail.com>
GiedriusS
reviewed
Jan 11, 2022
pkg/prober/intrumentation.go
Outdated
| p.mu.Lock() | ||
| defer p.mu.Unlock() | ||
| if p.statusString != ready { | ||
| level.Info(p.logger).Log("msg", "changing probe status", "status", "ready") |
There was a problem hiding this comment.
Suggested change
| level.Info(p.logger).Log("msg", "changing probe status", "status", "ready") | |
| level.Info(p.logger).Log("msg", "changing probe status", "status", ready) |
Signed-off-by: Juozas Vainauskas <vainauskasjuozas@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #5036
Changes
Remove constant spam of "changing probe status" if status of the probe was set to the same value as before
Verification
I ran
make quickstartwithout my changes and saw that"changing probe status"messages are spammed even though probe status was set to the same value as before. Then I added my changes, ranmake quickstartagain and got certain that these kind of logs do not repeat if probe status does not change to different value than before.