Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compactor: Adding minimum retention flag validation for downsampling retention #5059

Merged
merged 6 commits into from
Jan 21, 2022
Merged

Compactor: Adding minimum retention flag validation for downsampling retention #5059

merged 6 commits into from
Jan 21, 2022

Commits on Jan 10, 2022

  1. Renaming DownsampleRange -> ResLevel1DownsampleRange to specify t… 

    …he mapping between the downsample ranges and their respective resolutions

Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    c31cb08 View commit details
    Browse the repository at this point in the history

  2. Adding compactor downsample retention flag validation... 

    ...if the following conditions are met:
* Downsampling is enabled, raw retention must be > 10 days
* Downsampling is enabled, 5m resolution retention must be at least 40h
* Downsampling is enabled, 1h resolution must be at least 10d

This is to avoid unexpected deletions of downsampled/raw data as compactor will only downsample raw blocks after there is enough data to form 2 whole blocks, it will not downsample immediately.

Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    bd1f9ca View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Added more clarifying docs on impact of retention on downsampling 

    Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    d7dded1 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Resolving conflicts 

    Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    c25f2ff View commit details
    Browse the repository at this point in the history

  2. Updated CHANGELOG.md 

    Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    cd64ebf View commit details
    Browse the repository at this point in the history

  3. Addressing PR comments 

    Signed-off-by: mzardab <mzardab@redhat.com>
    @moadz
    moadz committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    26d20d9 View commit details
    Browse the repository at this point in the history