*: Attempt to fix multiarch builds by updating remote Docker engine version #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
|
It's looking good, this time the emulator was installed - https://app.circleci.com/pipelines/github/thanos-io/thanos/8646/workflows/fda3dfa9-d706-47c8-8df1-b32ec8c8976e/jobs/17975/parallel-runs/0/steps/0-107 |
|
Tests are successful 👍 - https://app.circleci.com/pipelines/github/thanos-io/thanos/8646/workflows/fda3dfa9-d706-47c8-8df1-b32ec8c8976e/jobs/17975. Removing the test commit and opening this up for review. |
matej-g
force-pushed
the
attempt-fix-multiarch-builds
branch
from
144db13 to
b94392a
Compare
matej-g
changed the title
|
publish_main works 🎉 |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR attempts to fix current issue on CI - #5077 - which causes the
publish_*jobs not to pass on the CircleCI.The first attempt is to update the remote Docker engine version (see: https://circleci.com/docs/2.0/building-docker-images/#docker-version)
Temporarily, the job has been allowed on all branches but pushing images has been commented out, we just need to make sure we pass the
docker-teststepVerification
Waiting on CI to pass