Support triggering update sha workflow manually #5093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
Signed-off-by: Ben Ye <ben.ye@bytedance.com>
|
CI failure seems unrelated? |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
* support triggering update sha workflow manually Signed-off-by: Ben Ye <ben.ye@bytedance.com> * update syntax Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ben Ye ben.ye@bytedance.com
Changes
Now the workflow is triggered by a cron job every day. But if the busybox image is updated after running the cron job that day, then the CI will be broken until the next day.
To support better control on this, I added support to trigger it manually. See doc https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#workflow_dispatch.
Verification
I am not sure if the current syntax is correct or not so would be great to have more eyes for review.