Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed typo in sidecar docs #5099

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Fixed typo in sidecar docs #5099

merged 1 commit into from
Jan 26, 2022

Conversation

PabloL007
Copy link
Contributor

@PabloL007 PabloL007 commented Jan 25, 2022

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Changed ...on order to use... to ...in order to use... in the object storage upload instructions for the sidecar component
  • Changed ...which is needed to avoid the uploaded data corruption... to ...which is needed to avoid the corruption of uploaded data... in the object storage upload instructions for the sidecar component

Verification

N/A

@squat
Copy link
Member

squat commented Jan 25, 2022

Thanks @PabloL007
Please sign the DCA so that we can merge your PR :))

hint: git commit --amend --signoff

Signed-off-by: PabloL007 <pablo_ley@hotmail.com>
@PabloL007
Copy link
Contributor Author

@squat updated, thanks!

@squat squat enabled auto-merge (squash) January 25, 2022 14:33
@GiedriusS GiedriusS disabled auto-merge January 26, 2022 07:39
@GiedriusS GiedriusS merged commit ce82cf3 into thanos-io:main Jan 26, 2022
@PabloL007 PabloL007 deleted the patch-1 branch January 26, 2022 08:56
Nicholaswang pushed a commit to Nicholaswang/thanos that referenced this pull request Mar 6, 2022
Signed-off-by: PabloL007 <pablo_ley@hotmail.com>
Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants