Docs: Remove link to a deleted resource from mixin docs #5107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matej Gera <matejgera@gmail.com>
GiedriusS
approved these changes
Jan 28, 2022
Yeah, I quickly looked around if it has been moved, but no luck. Perhaps if we could reach @tomwilkie who seem to be the author (guessing from https://groups.google.com/g/prometheus-developers/c/ADgiqnaT1wo/m/BEY9sZfbAQAJ) maybe we could get an alternative link. |
|
Sorry about that, I don't know what happened there! Heres a PDF we cached a while back: https://github.com/monitoring-mixins/docs/blob/master/design.pdf, but I think that doc was written under the Kausal google account, which is long gone now. |
2 tasks
|
Awesome, thanks for providing the link @tomwilkie! |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
Signed-off-by: Matej Gera <matejgera@gmail.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Matej Gera matejgera@gmail.com
Changes
Deleting link to mixin design doc (https://docs.google.com/document/d/1A9xvzwqnFVSOZ5fD3blKODXfsat5fg6ZhnKu9LK3lB4/edit#) which apparently does not exist anymore and causes the doc check to fail.
Verification
Local run of
make check-docs