feat bucket replicate: added flag to ignore blocks marked for deletion #5117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
FUSAKLA
force-pushed
the
fus-replicate-ignore-deleted
branch
from
96b74f6
to
d0f58ef
Compare
GiedriusS
reviewed
Feb 3, 2022
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
FUSAKLA
force-pushed
the
fus-replicate-ignore-deleted
branch
from
ef9a1fa
to
53bab98
Compare
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
|
Thanks, @GiedriusS for the swift review! The white space changes were caused by the |
|
Passing through the docs test is a task on its own I see, might consider making it the default, so I do not have to add any flags 😄 |
GiedriusS
previously approved these changes
Feb 4, 2022
wiardvanrij
reviewed
Feb 5, 2022
|
Only got one question, other than that, LGTM! :) |
Signed-off-by: Martin Chodur <m.chodur@seznam.cz>
|
Not sure why but the PR diff broke GitHub somehow 😅 |
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
thanos-io#5117) * feat bucket replicate: added flag to ignore blocks marked for deletion Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * cr: fix docs and test Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * cr: add debug log on failed deletion mark read Signed-off-by: Martin Chodur <m.chodur@seznam.cz> * cr: return error instead of logging issues with reading deletion marks Signed-off-by: Martin Chodur <m.chodur@seznam.cz> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, we bumped into some race conditions with
tools bucket replicatefrom bucket with a compactor running, such as replication of a block that just gets deleted by compactor.Also, this can save some bandwidth, since it's mostly useless to sync blocks that will be deleted eventually.
Would you be ok accepting this? I'm open to any suggestions., thanks!
Changes
--ignore-marked-for-deletionto thethanos bucket replicatecommandVerification