Added logo #5150

tend2infinity · 2022-02-13T15:08:03Z

Signed-off-by: soumya somu12.ss@gmail.com

I added CHANGELOG entry for this change.
Change is not relevant to the end user.

Issue #5121

Changes

Added logo

Verification

Tested locally

UI Screenshot

squat

:)

Nexucis · 2022-02-13T22:41:09Z

pkg/ui/react-app/src/thanos/Navbar.tsx

@@ -104,6 +104,7 @@ const Navigation: FC<PathPrefixProps & NavigationProps> = ({ pathPrefix, thanosC
    <Navbar className="mb-3" dark color="dark" expand="md" fixed="top">
      <NavbarToggler onClick={toggle} className="mr-2" />
      <Link className="navbar-brand" to={`${pathPrefix}${defaultRoute}`}>
+        <img src="https://thanos.io/icon-dark.png" alt="thanos" style={{ width: '2rem', marginRight: '0.5rem' }} />


I believe it would be interesting to have it locally. Otherwise server that doesn't have access to internet won't be able to display the logo :/

In case it can help, this is how we did it in Prometheus : prometheus/prometheus#10236

Hey @Nexucis looks alright?

could you run the command make assets at the root of the project ? And then commit the modification of the files

I already did that, there isn't any modification apart from what I committed

after running make assets :

git status On branch logo Your branch is up to date with 'origin/logo'. Changes not staged for commit: (use "git add <file>..." to update what will be committed) (use "git restore <file>..." to discard changes in working directory) modified: pkg/ui/bindata.go no changes added to commit (use "git add" and/or "git commit -a")

maybe you didn't push every changes

excepting the asset issue, it looks good to me. I'm just wondering if it would be cleaner to put the style in a dedicated css class.
@onprem any thought around this ?

maybe you didn't push every changes

Do you want me to add the bindata.go file as well, it had a lot of changes that's why I didn't add it!

yes that's exactly what you have to do

metalmatze · 2022-02-14T14:09:19Z

Love it!
One last run with make docs might fix the last broken CI.

Nexucis · 2022-02-17T13:21:20Z

Soooo after talking a bit with @matej-g, it appears that the issue regarding the doc is tracked with #4732 and there is a short fix with #5167.

So I would suggest that you revert the changes related to the doc @tend2infinity in this PR. Hopefully once #5167 is merged, the CI in this PR will be green.

Nexucis · 2022-02-24T09:26:22Z

you still have to run make assets and commit the file changed @tend2infinity ;)

kakkoyun

Nice!

Nexucis · 2022-02-24T11:31:59Z

cool, now we are good @tend2infinity, thanks !

back to you guys @kakkoyun @metalmatze :)

Nexucis · 2022-02-24T11:33:05Z

ah no wait, you have some conflict @tend2infinity. Probably better to rebase the PR with the last changes from the main branch and then re-run make assets

tend2infinity · 2022-02-24T11:38:43Z

ah no wait, you have some conflict @tend2infinity. Probably better to rebase the PR with the last changes from the main branch and then re-run make assets

Yup, I rebased, I feel now we should be good to go

Nexucis · 2022-02-24T15:05:49Z

It looks like the file bind_data.go isn't well generated or formated. Did you get an error when running the command @tend2infinity ?

tend2infinity · 2022-02-25T08:49:56Z

Seems like docs are failing for almost all of my PRs 👀

squat · 2022-02-26T13:25:20Z

@tend2infinity could you rebase on main? Docs are building correctly there and there were done changes recently

bwplotka · 2022-04-07T08:23:38Z

Friendly ping (:

Nexucis · 2022-04-23T20:03:28Z

@tend2infinity if you are not available anymore, I could take back your PR and rebase it if you want, so we can merge it :).

tend2infinity · 2022-04-27T16:08:55Z

Hey @Nexucis really sorry couldn't catch up, actually have my exams right now, will update this as soon as I get time

adithyaakrishna · 2022-05-16T12:21:59Z

@tend2infinity Can I take this up? 👀

Nexucis · 2022-06-07T10:21:16Z

any chance you have some time to rebase this PR @tend2infinity ?

tend2infinity · 2022-06-19T09:01:15Z

Its been a while since I looked upon this issue and right now um facing a lot of conflicts while rebasing the branch, maybe we can close this issue and open a clone of this and make the same changes in a new branch

Nexucis · 2022-06-19T19:39:14Z

if it's too hard to rebase, maybe you could simply merge the main branch in yours.

And if the conflicts are still too hard to resolve, another way around to do it, is to erase your local branch with the last commit from the main branch. And then copy and past the changes you can find in this PR. Commit your changes, and force push. So it doesn't change the branch and so the PR.

Signed-off-by: tend2infinity <somu12.ss@gmail.com>

tend2infinity · 2022-06-19T21:39:06Z

if it's too hard to rebase, maybe you could simply merge the main branch in yours.

And if the conflicts are still too hard to resolve, another way around to do it, is to erase your local branch with the last commit from the main branch. And then copy and past the changes you can find in this PR. Commit your changes, and force push. So it doesn't change the branch and so the PR.

Done exactly the same, I guess it must be fixed now

Nexucis

Thanks @tend2infinity.
It looks good to me :).

Nexucis · 2022-06-20T08:23:12Z

if someone from the thanos team can rerun the github action, it will hopefully work :). And then probably it will be the good time to merge if you are agree too ;)

stale · 2022-09-21T00:13:19Z

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

Nexucis · 2022-09-22T07:34:44Z

yes it is still relevant, but I have no idea why it has not been merged. Perhaps there was still a blocking point

squat

@tend2infinity could you regenerate the bindata file? After that we can merge 🚢

stale · 2022-10-30T00:23:15Z

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

yeya24 · 2022-10-30T18:35:14Z

Hi @tend2infinity, are you still planning to finish this pr? If not, I am happy to help resolve the merge conflict and get this in!

stale · 2023-01-07T21:35:09Z

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

Nexucis · 2023-04-12T12:31:18Z

this PR can be closed as the logo has been added thanks to the PR #6264 :)

pull-request-size bot added the size/XS label Feb 13, 2022

squat previously approved these changes Feb 13, 2022

View reviewed changes

Nexucis reviewed Feb 13, 2022

View reviewed changes

tend2infinity dismissed squat’s stale review via d24e5e6 February 14, 2022 09:27

pull-request-size bot added size/L and removed size/XS labels Feb 14, 2022

pull-request-size bot added size/XL and removed size/L labels Feb 15, 2022

pull-request-size bot added size/XS and removed size/XL labels Feb 23, 2022

kakkoyun reviewed Feb 24, 2022

View reviewed changes

pull-request-size bot added size/L and removed size/XS labels Feb 24, 2022

added icon for navbar

6aa39d2

Signed-off-by: tend2infinity <somu12.ss@gmail.com>

Nexucis approved these changes Jun 20, 2022

View reviewed changes

matej-g approved these changes Jun 20, 2022

View reviewed changes

stale bot added the stale label Sep 21, 2022

stale bot removed the stale label Sep 22, 2022

squat requested changes Sep 22, 2022

View reviewed changes

stale bot added the stale label Oct 30, 2022

stale bot removed the stale label Oct 30, 2022

stale bot added the stale label Jan 7, 2023

Nexucis mentioned this pull request Apr 3, 2023

UI: Add Thanos Logo in the navbar #5121

Closed

stale bot removed the stale label Apr 12, 2023

matej-g closed this Apr 19, 2023

Added logo #5150

Added logo #5150

Conversation

tend2infinity commented Feb 13, 2022

Changes

Verification

UI Screenshot

squat left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Nexucis Feb 13, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

metalmatze commented Feb 14, 2022

Nexucis commented Feb 17, 2022

Nexucis commented Feb 24, 2022

kakkoyun left a comment

Choose a reason for hiding this comment

Nexucis commented Feb 24, 2022

Nexucis commented Feb 24, 2022

tend2infinity commented Feb 24, 2022

Nexucis commented Feb 24, 2022

tend2infinity commented Feb 25, 2022

squat commented Feb 26, 2022

bwplotka commented Apr 7, 2022

Nexucis commented Apr 23, 2022

tend2infinity commented Apr 27, 2022

adithyaakrishna commented May 16, 2022

Nexucis commented Jun 7, 2022

tend2infinity commented Jun 19, 2022

Nexucis commented Jun 19, 2022

tend2infinity commented Jun 19, 2022

Nexucis left a comment • edited Loading

Choose a reason for hiding this comment

Nexucis commented Jun 20, 2022

stale bot commented Sep 21, 2022

Nexucis commented Sep 22, 2022

squat left a comment

Choose a reason for hiding this comment

stale bot commented Oct 30, 2022

yeya24 commented Oct 30, 2022

stale bot commented Jan 7, 2023

Nexucis commented Apr 12, 2023

Nexucis Feb 13, 2022 •

edited

Loading

Nexucis left a comment •

edited

Loading