COS: Fix tools replicate #5166
Merged
COS: Fix tools replicate #5166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
hanjm
changed the title
hanjm
changed the title
hanjm
force-pushed
the
fix/jimmiehan-fix-objsize
branch
from
8e3b658
to
e66d927
Compare
|
docs check fail, it will fixed by #5167 (: |
|
Can you please rebase main? The doc should be fixed already on main. |
yeya24
previously approved these changes
Feb 21, 2022
There was a problem hiding this comment.
Looks like https://github.com/thanos-io/thanos/pull/4687/files is overlapped with this pr.
hanjm
force-pushed
the
fix/jimmiehan-fix-objsize
branch
2 times, most recently
from
a2d07a2
to
6d55947
Compare
Thank you reviewing. 🚀 Rebase Done. |
…dCloser Signed-off-by: Jimmie Han <hanjinming@outlook.com>
Signed-off-by: Jimmie Han <hanjinming@outlook.com>
hanjm
force-pushed
the
fix/jimmiehan-fix-objsize
branch
from
6d55947
to
ad72427
Compare
|
@yeya24 some e2e test is flaky, I retry it. Please review again, thank you. |
Merged
hanjm
force-pushed
the
fix/jimmiehan-fix-objsize
branch
from
98d6fb3
to
4100da5
Compare
GiedriusS
approved these changes
Feb 25, 2022
Nicholaswang
pushed a commit
to Nicholaswang/thanos
that referenced
this pull request
Mar 6, 2022
* objstore: fix TryToGetSize err when the reader wrappered by TimingReadCloser Signed-off-by: Jimmie Han <hanjinming@outlook.com> * COS: Add size info into reader for pass it to Upload function. Signed-off-by: Jimmie Han <hanjinming@outlook.com> * Fix typo Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com> Signed-off-by: Jimmie Han <hanjinming@outlook.com> Co-authored-by: Matej Gera <38492574+matej-g@users.noreply.github.com> Signed-off-by: Nicholaswang <wzhever@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue reported by @wu3396 (#5139 (comment) ), pr #5139 introduce multi-part upload, it uses TryToGetSize to get the size of
reader, but it will error when the reader is wrapped by TimingReadCloser. this pr continue to fix it.TryToGetSizeerror when the reader wrappered byTimingReadCloser, It will also fixcos/s3/bos/swiftget size error when useobjstore.TryToGetSize(r).(*bucket).Getfor pass it to(*bucket).Uploadfunction.Signed-off-by: Jimmie Han hanjinming@outlook.com
Changes
Verification
thanos tool replicateto reproduce the issue and verify.