E2E Tests: Improve Prometheus configurability and make query tests more resilient #5181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move prom config method to shared e2ethanos package - Make scraping Prometheus instance optional Signed-off-by: Matej Gera <matejgera@gmail.com>
Signed-off-by: Matej Gera <matejgera@gmail.com>
hanjm
reviewed
Feb 24, 2022
Signed-off-by: Matej Gera <matejgera@gmail.com>
saswatamcode
previously approved these changes
Mar 2, 2022
bwplotka
previously approved these changes
Mar 2, 2022
Signed-off-by: Matej Gera <matejgera@gmail.com>
2 tasks
|
Done, should be good to go now! |
GiedriusS
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
I have noticed that some of the query E2E tests are prone to flakiness, I've seen a couple CI failures (e.g. https://github.com/thanos-io/thanos/runs/5262364980?check_suite_focus=true#step:5:383) as well as failed runs locally.
The tests fail due to an out of bounds error upon trying to remote write, excerpt:
I suspect this is due to the fact that in some test cases, we're remote writing time series with timestamps in the past. However, since with the current default Prometheus configuration, Prometheus is configured to scrape itself as well. I suspect that on occasion, if Prometheus is scraped before remote write, this makes the minimum valid time to be set to 'now', which causes the remote write requests with past timestamps to return out of bounds error.
The change to mitigate here is to make the self-scraping of the test Prometheus instance optional, as for these mentioned test cases this might interfere with remote write requests. Additionally, I moved the Prometheus config method to
e2ethanospackage from the query test file, since it's used across multiple E2E tests and fits better there. Lastly, I bumped slightly the wait time forminioto be ready, since I'm still seeing on occasion error whenminiois not ready to accept requests.Verification
Ran E2E locally multiple times with success (as opposed to hitting out of bounds error before).