-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: Move objstore out of repo #5254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work, thanks!
Seems like there are a few more places that need their imports updated. |
Do we have a plan when the switch is going to be made? Thinking where the best place to make changes is. |
I think it is confusing to still keep objstore in the THanos codebase. Especially we have changes like #5337. |
I have a PR to update the Azure object store that I want to start testing in my environment. Is this going to be merged or is it a safe bet to create a new PR to the Thanos repo? |
Yes, we want to merge this, but it requires more work to make it happen. Also, https://github.com/thanos-io/objstore requires more work in terms of CI and documentation. Normally I would propose to @phillebaba to work on separate repo but we (and @phillebaba) won't be able to verify if the new code works. Thus I would say, unless @kakkoyun @brancz @yeya24 or anyone else has time to finalize this work within next 2 weeks - we should, unfortunately, stick to Thanos codebase. I am ultra busy with book for next weeks, will have more time after that ): |
I'm happy to help with this issue and handle the CI work for the separate repo. Is anyone working on anything related to this? |
Check with your CEO, otherwise I think you are good ((((: |
Last I chatted with @onprem he wanted to do this and there was also a discussion about first removing the cortex dependency. Otherwise very happy if someone gets this moving! |
Pull request was converted to draft
It was easier to start over than fix the resolve conflicts #5510 |
Changes
Closes #3701
For this to go green we first need Cortex to migrate to the new dep.
Verification
Code and tests are unchanged, it's just moving code.
cc @onprem @kakkoyun @bwplotka @squat @pracucci @yeya24