Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: Move objstore out of repo #5254

Closed
wants to merge 1 commit into from
Closed

Conversation

brancz
Copy link
Member

@brancz brancz commented Mar 24, 2022

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Closes #3701

For this to go green we first need Cortex to migrate to the new dep.

Verification

Code and tests are unchanged, it's just moving code.

cc @onprem @kakkoyun @bwplotka @squat @pracucci @yeya24

Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work, thanks!

@bwplotka bwplotka enabled auto-merge (squash) March 25, 2022 11:35
@metalmatze
Copy link
Contributor

Seems like there are a few more places that need their imports updated.

@phillebaba
Copy link
Contributor

Do we have a plan when the switch is going to be made? Thinking where the best place to make changes is.

@kakkoyun
Copy link
Member

@brancz @onprem If you're not on it. I'm happy to take this one over.

@yeya24
Copy link
Contributor

yeya24 commented May 9, 2022

I think it is confusing to still keep objstore in the THanos codebase. Especially we have changes like #5337.
Let's move forward this if possible...

@phillebaba
Copy link
Contributor

I have a PR to update the Azure object store that I want to start testing in my environment.
thanos-io/objstore#3

Is this going to be merged or is it a safe bet to create a new PR to the Thanos repo?

@bwplotka
Copy link
Member

Yes, we want to merge this, but it requires more work to make it happen.

Also, https://github.com/thanos-io/objstore requires more work in terms of CI and documentation. Normally I would propose to @phillebaba to work on separate repo but we (and @phillebaba) won't be able to verify if the new code works. Thus I would say, unless @kakkoyun @brancz @yeya24 or anyone else has time to finalize this work within next 2 weeks - we should, unfortunately, stick to Thanos codebase. I am ultra busy with book for next weeks, will have more time after that ):

@kakkoyun
Copy link
Member

Yes, we want to merge this, but it requires more work to make it happen.

Also, https://github.com/thanos-io/objstore requires more work in terms of CI and documentation. Normally I would propose to @phillebaba to work on separate repo but we (and @phillebaba) won't be able to verify if the new code works. Thus I would say, unless @kakkoyun @brancz @yeya24 or anyone else has time to finalize this work within next 2 weeks - we should, unfortunately, stick to Thanos codebase. I am ultra busy with book for next weeks, will have more time after that ):

I'm happy to help with this issue and handle the CI work for the separate repo. Is anyone working on anything related to this?
Otherwise, I'll start planning my time for this.

@bwplotka
Copy link
Member

Check with your CEO, otherwise I think you are good ((((:

@brancz
Copy link
Member Author

brancz commented Jun 20, 2022

Last I chatted with @onprem he wanted to do this and there was also a discussion about first removing the cortex dependency. Otherwise very happy if someone gets this moving!

@kakkoyun kakkoyun added the package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore label Jul 8, 2022
@kakkoyun kakkoyun marked this pull request as draft July 8, 2022 13:23
auto-merge was automatically disabled July 8, 2022 13:23

Pull request was converted to draft

@kakkoyun
Copy link
Member

It was easier to start over than fix the resolve conflicts #5510

@kakkoyun kakkoyun closed this Jul 15, 2022
@brancz brancz deleted the move-objstore branch July 15, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: objstore Mark PRs and issues needs to be migrated to thanos-io/objstore size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Put objstore outside of Thanos main repo?
6 participants