Proposal: Granular Endpoint Configuration

[SrushtiSapkale]

Signed-off-by: Srushti Sapkale srushtiisapkale@gmail.com

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

[fpetkovski]

Having something like this would be great for using Queriers with Prometheus sidecars. However, I think it can be a big pitfall when federating multiple queriers through a single query endpoint.

A common use case with Thanos to have cluster-local or regional Queriers which are connected globally through one central Querier. The advantage of using Envoy in this case is that it can load-balance gRPC connections, something we currently don't support natively in Thanos. If people used the endpoints config to connect the global to the regional queriers, they will not be able to scale regional queriers due to the persistent nature of gRPC connections.

Because of that, I think this feature should be very clear on when the endpoint config can be useful versus using something like Envoy.

[saswatamcode]

Thanks for awesome work! 🌟

Some small suggestions! 🙂

[SrushtiSapkale]

Yes, thanks! we need to keep in mind that if the endpoint config is implemented we need a solution for scaling the querier. Also as @saswatamcode suggested, I think per store endpt configuration can a better option for distributed querier 👍

[SrushtiSapkale]

@saswatamcode can you review the changes in the proposal once again?:slightly_smiling_face:

[saswatamcode]

Amazing! Some suggestions,

[bwplotka]

Great job! Some suggestions we made during our 1:2

[bwplotka]

I wonder if we want to tacle the @yeya24 request to enable different API

[bwplotka]

I or @saswatamcode will add more context

[bwplotka]

Can I specify multiple endpoint.config flags?

[bwplotka]

cc me @saswatamcode

[stale]

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

[matej-g]

What's the status of this proposal and the implementation @SrushtiSapkale @saswatamcode @bwplotka? Looks like this was marked stale now.

[saswatamcode]

Yup, so the proposal has some bits that need improvement! Will TAL. 🙂

[SrushtiSapkale]

This proposal was a part of my lfx mentorship about implementing the endpoint configuration. Need to add some more points, would be happy to take this forward whenever it gets reviewed again 😅

[stale]

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

[stale]

Closing for now as promised, let us know if you need this to be reopened! 🤗