-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add panel Query Concurrency to dashboard mixin. #5542
Conversation
how to rerun the failing test? it seems like a transient error. |
examples/dashboards/query.json
Outdated
"steppedLine": false, | ||
"targets": [ | ||
{ | ||
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[5m]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[5m])", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[5m]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[5m])", | |
"expr": "max_over_time(thanos_query_concurrent_gate_queries_max{job=~\"$job\"}[$__rate_interval]) - avg_over_time(thanos_query_concurrent_gate_queries_in_flight{job=~\"$job\"}[$__rate_interval])", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, Filip :) The PR has been updated accordingly.
In the same file there is a variable $interval
. Is it equivalent to $__rate_interval
?
Hey @raptorsun, can you have a look at the feedback so that we can proceed with merging your contribution, please? 🙏 To rerun the build in case it fails, you can push an empty commit. Here's how you can create an empty commit: |
Small tip: maybe rebasing with |
b4d41bd
to
a831574
Compare
The PR has been rebased on latest main branch now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
Thanks, @raptorsun!
Signed-off-by: Haoyu Sun <hasun@redhat.com>
a831574
to
e5987af
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this was forgotten, but looks good! Thanks!
Signed-off-by: Haoyu Sun <hasun@redhat.com> Signed-off-by: Haoyu Sun <hasun@redhat.com>
Changes
add a panel "Query Concurrency" to the dashboard mixin, showing the available capacity to serve concurrent queries.
Verification
add the dashboard to grafana to check it.
The panel should look like this: