[file-sd-part-4] Added flag for query addresses to ruler #555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
fca9f88
to
5bf8121
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
3f90e9a
to
a2d9591
Compare
ivan-valkov
force-pushed
the
file-sd-rule
branch
2 times, most recently
from
0c68519
to
b9a7cf0
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
a2d9591
to
a337452
Compare
ivan-valkov
changed the title
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
b9a7cf0
to
75ea2e7
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
a337452
to
d81dd66
Compare
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
75ea2e7
to
965b239
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
d81dd66
to
e37fc01
Compare
domgreen
requested changes
Oct 12, 2018
| @@ -192,6 +212,8 @@ func runRule( | |||
| // back or the context get canceled. | |||
| queryFn := func(ctx context.Context, q string, t time.Time) (promql.Vector, error) { | |||
| var addrs []string | |||
| // Add addresses from static flag | |||
| addrs = append(addrs, queryAddrs...) | |||
There was a problem hiding this comment.
Within queryFn do we want to remove duplicates if they exist.
There was a problem hiding this comment.
May even want to do this in #547 as we could supply a value in the file that its picked up by gossip as well if both systems are running.
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
965b239
to
e5c31e4
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
e37fc01
to
db61524
Compare
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
e5c31e4
to
e5bcfed
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
db61524
to
6150f6b
Compare
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
e5bcfed
to
7180ccc
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
2 times, most recently
from
d6e4c5a
to
136d7d6
Compare
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
28392c6
to
7d55dfc
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
136d7d6
to
b7ec7a0
Compare
domgreen
approved these changes
Oct 16, 2018
ivan-valkov
force-pushed
the
file-sd-rule
branch
from
7d55dfc
to
3e4abbd
Compare
ivan-valkov
force-pushed
the
query-flag-rule
branch
from
b7ec7a0
to
2e1dfe9
Compare
…ns (#556) * Added tests for rule filesd and static flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds the option to statically configure the queriers that ruler talks to via a command line flag.
Not exactly fileSD related, but it can be useful as a static alternative to gossip.
Verification
Validated in a following PR - (#556)