Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi-tenant exemplar matchers #5554

Merged
merged 2 commits into from
Aug 1, 2022
Merged

Fix multi-tenant exemplar matchers #5554

merged 2 commits into from
Aug 1, 2022

Commits on Aug 1, 2022

  1. Fix multi-tenant exemplar matchers 

    The exemplar proxy synthesizes a query based on PromQL expression matchers
and individual store's label sets. When a store has multiple label sets
with same label names but different values (e.g. multitenant Receivers),
each exemplar matcher will be repeated once for each label set. Because of this,
a receiver hosting 200 tenants can get the same exemplar matcher 200 times. This leads
to the underlying stores slowing down and timing out when asked for exemplars.

This commit modifies the exemplar proxy to deduplicate matchers and only send
a matcher once to an underlying store.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    1bbd985 View commit details
    Browse the repository at this point in the history

  2. Address CR comments 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Aug 1, 2022
    Configuration menu
    Copy the full SHA
    ba20cf0 View commit details
    Browse the repository at this point in the history