Implement Granular Endpoint Configuration #5585
Conversation
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
SrushtiSapkale
force-pushed
the
endpoints
branch
4 times, most recently
from
5f341e7
to
6c6e23e
Compare
There was a problem hiding this comment.
Thanks for the awesome work @SrushtiSapkale! 🌟
Added some comments! 🙂
pkg/query/config.go
Outdated
| cfg := EndpointConfig{} | ||
| cfg.Endpoints = endpointAddrs | ||
| if globalFileSDConfig.Files != nil { | ||
| cfg.EndpointsSD = []httpconfig.FileSDConfig{ |
There was a problem hiding this comment.
So we can maybe add a new field to the EndpointConfig struct, something like EndpointSDDiscoverer and in LoadConfig we can use file.NewDiscovery to process all the file SD configs and populate the new field. We would then be able to use the discoverers directly in query.go with fileSDCache. Wdyt?
There was a problem hiding this comment.
I tried adding endpointSDDiscoverer in query.go and the test is passing, wdyt is more preferable? 😅
There was a problem hiding this comment.
Hello @saswatamcode thanks a lot for the feedback, I also tried making some changes. Can u please review if they are helpful or we should keep it the way you suggested 😄
SrushtiSapkale
force-pushed
the
endpoints
branch
from
727ee9e
to
4be755d
Compare
Signed-off-by: Srushti Sapkale <srushtiisapkale@gmail.com>
Signed-off-by: Srushti Sapkale <srushtiisapkale@gmail.com>
Signed-off-by: Srushti Sapkale <srushtiisapkale@gmail.com>
|
Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days. |
|
Closing for now as promised, let us know if you need this to be reopened! 🤗 |
Signed-off-by: Srushti Sapkale srushtiisapkale@gmail.com
This PR is a part of implementing granular endpoint configuration
Proposal WIP #5505
--endpoint.configflag