Remove hardcoded labels in store shard matcher and inject unshardable label in query analyzer

[haanhvu]

Signed-off-by: haanhvu haanh6594@gmail.com

fixes #5625

• I added CHANGELOG entry for this change.
• Change is not relevant to the end user.

Changes

Remove hardcoded __name__ label in store shard matcher to make it shardable. Inject unshardable le label in query analyzer.

Verification

[haanhvu]

Convert to draft to fix errors and warnings

[fpetkovski]

Thanks for the contribution. We should also add tests for this change.

[haanhvu]

Thanks for the contribution. We should also add tests for this change.

@fpetkovski actually I didn't add the test because I see we already have one test case with le label?

thanos/pkg/querysharding/analyzer_test.go

Lines 125 to 126 in 544d67a

	expression: "histogram_quantile(0.95, sum(rate(metric[1m])) by (le, cluster))",
	shardingLabels: []string{"cluster"},

[haanhvu]

@fpetkovski I fixed all the suggestions. Pls review.

Thanks for the contribution. We should also add tests for this change.

@fpetkovski actually I didn't add the test because I see we already have one test case with le label?

thanos/pkg/querysharding/analyzer_test.go

Lines 125 to 126 in 544d67a

	expression: "histogram_quantile(0.95, sum(rate(metric[1m])) by (le, cluster))",
	shardingLabels: []string{"cluster"},

We already have a shardableByLabels test case. So I just add a shardableWithoutLabels test case.

Also, could you review #5653 too?

[fpetkovski]

Thanks, I can take a look at this tomorrow.

[fpetkovski]

Looks good, I would just prefer to use locally scoped variables instead of declaring shardingLabels with a broad scope.

[haanhvu]

@fpetkovski done converting to local variables

[fpetkovski]

Thanks, this is nice work 👍

LGTM.

[matej-g]

Looks good 🙌, one nit

[matej-g]

Nice work @haanhvu ❤️