Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cache vertical shards in query frontend #5648

Merged
merged 3 commits into from
Sep 4, 2022
Merged

Cache vertical shards in query frontend #5648

merged 3 commits into from
Sep 4, 2022

Commits on Aug 31, 2022

  1. Cache vertical shards in query frontend 

    The vertical sharding middleware is currently executed after the
caching middleware. Because of this, individual vertical shards are
not getting cached when the succeed. Caching is only done when the
entire requests including all shards complete successfully.

This commit moves the vertical sharding middleware before the caching
middleware. It also modifies caching keys to contain the total shards
and the shard number so that each vertical shard gets an independent
caching key.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    ea372a4 View commit details
    Browse the repository at this point in the history

  2. Adjust cache key tests 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    40fab1d View commit details
    Browse the repository at this point in the history

  3. Remove source of flakiness by using sync.Cond 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Aug 31, 2022
    Configuration menu
    Copy the full SHA
    9962948 View commit details
    Browse the repository at this point in the history