replaced crypto/sha with https://github.com/minio/sha256-simd #5738
Conversation
Signed-off-by: utukj <utukphd@gmail.com>
internal/cortex/chunk/schema_util.go
Outdated
| @@ -13,6 +12,8 @@ import ( | |||
| "strings" | |||
| "sync" | |||
|
|
|||
| "github.com/minio/sha256-simd" | |||
|
|
|||
| "fmt" | |||
pkg/block/metadata/hash.go
Outdated
| "encoding/hex" | ||
| "fmt" | ||
| "io" | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/minio/sha256-simd" |
There was a problem hiding this comment.
ditto, let's merge this with the section starting from line 15
pkg/reloader/reloader.go
Outdated
| // - Watch on changes against certain file e.g (`cfgFile`). | ||
| // - Optionally, specify different output file for watched `cfgFile` (`cfgOutputFile`). | ||
| // This will also try decompress the `cfgFile` if needed and substitute ALL the envvars using Kubernetes substitution format: (`$(var)`) | ||
| // - Watch on changes against certain directories (`watchedDirs`). |
There was a problem hiding this comment.
Umm, why these are changed? Let's update them back
pkg/reloader/reloader.go
Outdated
| @@ -69,6 +68,8 @@ import ( | |||
| "sync" | |||
| "time" | |||
|
|
|||
| "github.com/minio/sha256-simd" | |||
There was a problem hiding this comment.
oops. I think a go fmt extension did that.
Signed-off-by: utukj <utukphd@gmail.com>
utukJ
force-pushed
the
sha256-package-replace
branch
from
e6201e7
to
6c73ea0
Compare
|
Flake, so restarted CI job: |
|
I know we talked about testing this with other OS-es: #5722 (comment), however testing manually anything is not sustainable. If our CI is green, we should merge it. If image build is failing later on on main, we should add extra check for that in the PR CI - it's not sustainable for community to manually test things like that, especially as likely no one runs Thanos on freeBSD or ppc64le and we don't claim full support for that (yet). |
|
For future - we should benchmark if this extra deps was even worth it 🙈 |
|
cc #5764 |
…-io#5738) * replaced crypto/sha with https://github.com/minio/sha256-simd Signed-off-by: utukj <utukphd@gmail.com> * fixed import grouping Signed-off-by: utukj <utukphd@gmail.com> Signed-off-by: utukj <utukphd@gmail.com>
|
Is a cryptographically-strong digest really needed for this use case? If the goal is just to have a high quality but also fast hash, maybe it makes sense to look at https://cyan4973.github.io/xxHash/. |
Signed-off-by: utukj utukphd@gmail.com
Changes
Replaced crypto/sha package with https://github.com/minio/sha256-simd
Verification