-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with Go 1.19 #5753
Build with Go 1.19 #5753
Conversation
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two comments, otherwise LGTM
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💪
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for always taking care of these upgrades 😄
* Build with Go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Run go fmt with go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Add changelog entry Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Revert go version in go.mod Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade faillint to v1.11.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade github.com/golangci/golangci-lint to v1.49.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Remove deprecated linters ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Regen proto files Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix typo Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Format docs Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade gopsutil to v3.22.9 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Display diff in the check-docs target Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix macOS path in docs/components/tools.md Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr>
* Build with Go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Run go fmt with go 1.19 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Add changelog entry Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Revert go version in go.mod Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade faillint to v1.11.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade github.com/golangci/golangci-lint to v1.49.0 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Remove deprecated linters ``` WARN [runner] The linter 'deadcode' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'varcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [runner] The linter 'structcheck' is deprecated (since v1.49.0) due to: The owner seems to have abandoned the linter. Replaced by unused. WARN [linters context] structcheck is disabled because of generics. You can track the evolution of the generics support by following the golangci/golangci-lint#2649. ``` Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Regen proto files Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix typo Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Format docs Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Upgrade gopsutil to v3.22.9 Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Display diff in the check-docs target Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> * Fix macOS path in docs/components/tools.md Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: Sylvain Rabot <sylvain@abstraction.fr> Signed-off-by: utukj <utukphd@gmail.com>
Changes
Build with Go 1.19
Verification