Cut 0.28.1 #5757
Merged
Cut 0.28.1 #5757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeya24
force-pushed
the
cut-0.28.1-rc.0
branch
from
b083ea4
to
e27f50d
Compare
|
Umm, I am not sure how should I fix the DCO issue. Should I signed off for |
|
Can't we just force it to pass? |
|
This change is small enough, I don't really see a need to cut a release candidate. Maybe just directly release 0.28.1. |
|
Hmmm seems like there is a residual email from my previous company that is messing things up. Added the reddit email to DCO maybe this will fix things? |
|
Unfortunately we seem to have issues with DCO all the time, even though all the commits are properly signed, not the first time during release. We should be fine skipping it IMHO if we manually verify the commits are signed. Otherwise agreed with @SuperQ, this might be fine without RC given it's a single small fix. |
|
Cool, I will skip the RC and cut the release. |
|
The DCO failure is because the commit has to be signed by the commiter. 5b5cdc9 was signed by @davinci26, but commited by @yeya24, so it needs to be signed also by @yeya24. |
|
Ah makes sense, because it's not the same as the original commit that was merged into main |
* Updates minio-go to v7.0.37 from v7.0.32 fixes #5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com>
Signed-off-by: Ben Ye <benye@amazon.com> add line Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
cut-0.28.1-rc.0
branch
from
e27f50d
to
cbbcf66
Compare
|
Thanks @douglascamata, this works! |
|
Still says |
Signed-off-by: Ben Ye <benye@amazon.com>
yeya24
force-pushed
the
cut-0.28.1-rc.0
branch
from
8ed97ea
to
101a4bf
Compare
|
@SuperQ Thanks, mind taking another look? |
squat
pushed a commit
that referenced
this pull request
Oct 7, 2022
* Cut 0.28.0-rc.0 (#5632) * cut 0.28.0-rc.0 Signed-off-by: Ben Ye <ben.ye@bytedance.com> * address review comments Signed-off-by: Ben Ye <ben.ye@bytedance.com> * mention experimental/hidden features Signed-off-by: Ben Ye <ben.ye@bytedance.com> * include #5607 in changelog Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> * cut v0.28.0 (#5647) Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> * Cut 0.28.1 (#5757) * Updates minio-go to v7.0.37 from v7.0.32 (#5702) * Updates minio-go to v7.0.37 from v7.0.32 fixes #5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> * update changelog and version Signed-off-by: Ben Ye <benye@amazon.com> add line Signed-off-by: Ben Ye <benye@amazon.com> * update version to 0.28.1 Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> Co-authored-by: Ben Ye <ben.ye@bytedance.com> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
utukJ
pushed a commit
to utukJ/thanos
that referenced
this pull request
Oct 13, 2022
* Cut 0.28.0-rc.0 (thanos-io#5632) * cut 0.28.0-rc.0 Signed-off-by: Ben Ye <ben.ye@bytedance.com> * address review comments Signed-off-by: Ben Ye <ben.ye@bytedance.com> * mention experimental/hidden features Signed-off-by: Ben Ye <ben.ye@bytedance.com> * include thanos-io#5607 in changelog Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> * cut v0.28.0 (thanos-io#5647) Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> * Cut 0.28.1 (thanos-io#5757) * Updates minio-go to v7.0.37 from v7.0.32 (thanos-io#5702) * Updates minio-go to v7.0.37 from v7.0.32 fixes thanos-io#5701 Changelog: minio/minio-go@v7.0.32...v7.0.37 Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> * Adds changelog entry Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> * update changelog and version Signed-off-by: Ben Ye <benye@amazon.com> add line Signed-off-by: Ben Ye <benye@amazon.com> * update version to 0.28.1 Signed-off-by: Ben Ye <benye@amazon.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: Ben Ye <ben.ye@bytedance.com> Signed-off-by: Sotiris Nanopoulos <sotiris.nanopoulos@reddit.com> Signed-off-by: Ben Ye <benye@amazon.com> Co-authored-by: Ben Ye <ben.ye@bytedance.com> Co-authored-by: Sotiris Nanopoulos <sonanopo@microsoft.com> Signed-off-by: utukj <utukphd@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
It is a little bit late now but the goal of this pr is to cut
v0.28.1-rc.0to mainly brings in https://github.com/thanos-io/thanos/pull/5702/files to fix panic due to minio.Verification