Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sharding behavior for vector matches #5799

Merged
merged 2 commits into from
Oct 20, 2022
Merged

Fix sharding behavior for vector matches #5799

merged 2 commits into from
Oct 20, 2022

Commits on Oct 19, 2022

  1. Fix sharding behavior for vector matches 

    When analyzing a query composed of boolean expression with a non-"on" vector match,
the current vertical sharding logic is incorrectly scoping to labels in the
vector match and changing the semantics of the query.

Example:
```
foo and without (lbl) bar
```

Signed-off-by: Samuel Dufel <samuel.dufel@shopify.com>
    @sdufel
    sdufel committed Oct 19, 2022
    Configuration menu
    Copy the full SHA
    3e4f24f View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2022

  1. Replace string literals with constants 

    Signed-off-by: Samuel Dufel <samuel.dufel@shopify.com>
    @sdufel
    sdufel committed Oct 20, 2022
    Configuration menu
    Copy the full SHA
    a8b39b5 View commit details
    Browse the repository at this point in the history