Short-circuit chunk dedup in proxy #5816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
short-circuit-chunk-dedup
branch
from
cc4e607 to
dd263fe
Compare
GiedriusS
previously approved these changes
Oct 25, 2022
The store proxy deduplicates series by calculating a hash on the each aggregate chunk. If at least one hash is not present in the dedup-map, the entire series chunk is added to the response, including all aggregate chunks. Because of this, we can short-circuit deduping chunks and stop early if any aggregate chunks is not previously seen. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
short-circuit-chunk-dedup
branch
from
dd263fe to
a39588a
Compare
|
Should be green now :) |
matej-g
approved these changes
Oct 25, 2022
GiedriusS
pushed a commit
to vinted/thanos
that referenced
this pull request
Oct 31, 2022
The store proxy deduplicates series by calculating a hash on the each aggregate chunk. If at least one hash is not present in the dedup-map, the entire series chunk is added to the response, including all aggregate chunks. Because of this, we can short-circuit deduping chunks and stop early if any aggregate chunks is not previously seen. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
The store proxy deduplicates series by calculating a hash on the each aggregate chunk. If at least one hash is not present in the dedup-map, the entire series chunk is added to the response, including all aggregate chunks. Because of this, we can short-circuit deduping chunks and stop early if any aggregate chunks is not previously seen. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The store proxy deduplicates series by calculating a hash on the each aggregate chunk. If at least one hash is not present in the dedup-map, the entire series chunk is added to the response, including all aggregate chunks.
Because of this, we can short-circuit deduping chunks and stop early if any aggregate chunks is not previously seen.
Signed-off-by: Filip Petkovski filip.petkovsky@gmail.com
Changes
Verification