-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Prometheus to v0.40.1 #5896
Merged
+1,062
−426
Merged
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
021ba97
Updated prometheus to v0.40.1
rabenhorst b8d0666
Uncommented log line
rabenhorst 073a1a6
Removed TODOs and fixed test message
rabenhorst 6bdd19a
Updated prom engine
rabenhorst ee234a8
Added missing nil check for delSeriesIterator and comment
rabenhorst b5ae2d9
Fixed comment
rabenhorst 6db24f1
Started working on e2e tests
rabenhorst 7de8e32
Added native histograms e2e tests
rabenhorst c4099ba
Updated
rabenhorst ea23828
Added license header to native histogram tests
rabenhorst e031d72
Added retry for TestQueryNativeHistograms
rabenhorst 624f880
Improved native histogram tests, added changelog and update prometheu…
rabenhorst 14eaabf
Fixed changelog
rabenhorst 46a4bde
Removed trailing space from changelog
rabenhorst 8ace1fb
Ran busy box updater
rabenhorst f1191b7
Merge branch 'main' into prometheus-v0.40.x
rabenhorst File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Added missing nil check for delSeriesIterator and comment
Signed-off-by: Sebastian Rabenhorst <sebastian.rabenhorst@shopify.com>
commit ee234a85d810002c1c001953f3e3d6b5e5c71b6a
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should just import flags from
exporter-toolkit
and pass those options. There is https://pkg.go.dev/github.com/prometheus/exporter-toolkit@v0.8.1/web/kingpinflag#AddFlagsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that would introduce more changes. I can do that in a separate followup PR. WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, follow-up sounds good!