compact: retry on cleanPartialMarked errors if possible #5922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cleanPartialMarked is calling SyncMetas which basically can have retriable errors. By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server. Signed-off-by: Seena Fallah <seenafallah@gmail.com>
GiedriusS
approved these changes
Nov 28, 2022
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
cleanPartialMarked is calling SyncMetas which basically can have retriable errors. By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server. Signed-off-by: Seena Fallah <seenafallah@gmail.com> Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
cleanPartialMarkedis callingSyncMetaswhich basically can have retriable errors. By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server.Signed-off-by: Seena Fallah seenafallah@gmail.com
Verification
e.g. By making
context deadline exceedederrors for theSyncMetasfunc.