Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compact: retry on cleanPartialMarked errors if possible #5922

Merged
merged 1 commit into from
Nov 28, 2022

Conversation

clwluvw
Copy link
Contributor

@clwluvw clwluvw commented Nov 27, 2022

Changes

cleanPartialMarked is calling SyncMetas which basically can have retriable errors. By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server.

Signed-off-by: Seena Fallah seenafallah@gmail.com

Verification

e.g. By making context deadline exceeded errors for the SyncMetas func.

cleanPartialMarked is calling SyncMetas which basically can have retriable errors.
By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm.

Copy link
Member

@saswatamcode saswatamcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@GiedriusS GiedriusS merged commit 86b4039 into thanos-io:main Nov 28, 2022
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request May 18, 2023
cleanPartialMarked is calling SyncMetas which basically can have retriable errors.
By checking for retriable errors and retrying, it can prevent the compact from shutdown the HTTP server.

Signed-off-by: Seena Fallah <seenafallah@gmail.com>

Signed-off-by: Seena Fallah <seenafallah@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants