Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLI tool to inspect stores #5942

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

CLI tool to inspect stores #5942

wants to merge 14 commits into from

Conversation

pedro-stanaka
Copy link
Contributor

@pedro-stanaka pedro-stanaka commented Dec 6, 2022 •
edited
Loading

Summary

I am adding a new CLI tool that fetches information from all stores (discovered through DNS SRV records) and display which stores have blocks that match a set of label pairs.

I am just laying the foundation here for other sub-commands to come, I don't want to add all of them in a single PR to avoid having a HUGE PR.

Note for reviewers: I did not know where to put auxiliary code for this tool. So I added it to cmd, let me know where it would be better to put this.

One other idea I had was to move these tools to a repository in the community org, then we could just import runnable functions here. This we could decouple lots of logic that lives inside of thanos but are not related to thanos directly.

Related to #5399

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Preview

Here is one example execution of the command in a deployment with over 200 store-gw instances:

14-20-xgumt-vh0qp

Changes

Verification

@pedro-stanaka pedro-stanaka force-pushed the feat/stores-blocks-inspect branch from 949e50f to c3c2fec Compare December 13, 2022 11:34
@pedro-stanaka pedro-stanaka force-pushed the feat/stores-blocks-inspect branch from 24e729d to 7c214a9 Compare December 14, 2022 15:57
@pedro-stanaka pedro-stanaka marked this pull request as ready for review December 14, 2022 16:27
@yeya24
Copy link
Contributor

yeya24 commented Dec 20, 2022

Hi @pedro-stanaka, could you please also attach some screenshots of how this tool looks like?

@pedro-stanaka
Copy link
Contributor Author

Hi @pedro-stanaka, could you please also attach some screenshots of how this tool looks like?

Added to the PR body.

@pedro-stanaka pedro-stanaka force-pushed the feat/stores-blocks-inspect branch from f54fe58 to fda7a9c Compare December 20, 2022 07:34
@pedro-stanaka pedro-stanaka force-pushed the feat/stores-blocks-inspect branch from fda7a9c to 324c708 Compare January 26, 2023 09:09
@pedro-stanaka
Adding rudimentary version of the tool, need refactor
dfe1894 
Started to implement CLI

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Initial setup

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
fixing lint
a02112f 
Importing uber atomic

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

removing println

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>

Adding headers

Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
make linter happy again (pb files - not related)
f2a9d7e 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Using table printer to display information
bd83abb 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Giving up on cache
3dd98df 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Improve docs
4f26773 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Undo unrelated changes
842a864 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Mod tidy
80cd7ce 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Adding docs
5425ee8 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka pedro-stanaka force-pushed the feat/stores-blocks-inspect branch from 324c708 to 5425ee8 Compare April 20, 2023 15:00
@pedro-stanaka
Solving deprecation issues
a19df05 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Moving code around
23136e8 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Update docs
817bf84 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Adding missing header to file;
733ba72 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@pedro-stanaka
Fixing docs
e03bf4c 
Signed-off-by: Pedro Tanaka <pedro.tanaka@shopify.com>
@stale
Copy link

stale bot commented May 21, 2023

Hello 👋 Looks like there was no activity on this amazing PR for the last 30 days.
Do you mind updating us on the status? Is there anything we can help with? If you plan to still work on it, just comment on this PR or push a commit. Thanks! 🤗
If there will be no activity in the next week, this issue will be closed (we can always reopen a PR if you get back to this!). Alternatively, use remind command if you wish to be reminded at some point in future.

@stale stale bot added the stale label May 21, 2023
@pedro-stanaka
Copy link
Contributor Author

Hello folks. Is this still of interest? Otherwise I can close the PR.

@stale stale bot removed the stale label May 22, 2023
@pedro-stanaka
Copy link
Contributor Author

/remind me in 1 week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift[bot] left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pedro-stanaka @yeya24