Fix mint and maxt for api/v1/series call #5966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The storage querier currently uses select hints to set the start and end time of the series select rpc. The same rpc is also used for the api/v1/series API which does not produce any hints. This commit changes the querier to use the mint and maxt from the query itself when selecting series from stores. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
fix-series-range
branch
from
cfd1c35
to
3c7fc8a
Compare
GiedriusS
approved these changes
Dec 14, 2022
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
May 18, 2023
* Fix mint and maxt for api/v1/series call The storage querier currently uses select hints to set the start and end time of the series select rpc. The same rpc is also used for the api/v1/series API which does not produce any hints. This commit changes the querier to use the mint and maxt from the query itself when selecting series from stores. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add CHANGELOG entry Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storage querier currently uses select hints to set the start and end time of the series select rpc. The same rpc is also used for the api/v1/series API which does not produce any hints.
This commit changes the querier to use the mint and maxt from the query itself when selecting series from stores.
Changes
Verification