Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mixin(Receive): Fix series/samples written rate #5989

Merged

Conversation

douglascamata
Copy link
Contributor

@douglascamata douglascamata commented Dec 20, 2022

Signed-off-by: Douglas Camata 159076+douglascamata@users.noreply.github.com

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

  • Fixed rates that were being applied to the _bucket histogram metrics instead of _sum.

Verification

Tested in my dev Grafana receiving real data.

@douglascamata douglascamata marked this pull request as ready for review December 20, 2022 11:18
fpetkovski
fpetkovski previously approved these changes Dec 20, 2022
Copy link
Contributor

@fpetkovski fpetkovski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>
@douglascamata
Copy link
Contributor Author

@fpetkovski I had forgotten to run make examples. Should be good now, sorry.

@fpetkovski fpetkovski enabled auto-merge December 20, 2022 12:00
@fpetkovski fpetkovski merged commit 0e37f93 into thanos-io:main Dec 20, 2022
douglascamata added a commit to rhobs/configuration that referenced this pull request Jan 11, 2023
Signed-off-by: Douglas Camata <159076+douglascamata@users.noreply.github.com>

This should include the following PRs to improve the Store dashboard, with the ultimate goal in helping out deciding values for its limits:

* thanos-io/thanos#5989
* thanos-io/thanos#5838
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants