Use $__rate_inteval in Thanos mixin dashboards #6052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielmellado
force-pushed
the
change_to_rate_interval
branch
from
cab4625
to
eca2068
Compare
|
@douglascamata ^^ Thanks! :) |
danielmellado
force-pushed
the
change_to_rate_interval
branch
from
eca2068
to
1c1511b
Compare
This PR changes the Thanos mixin dashboard widgets that are using the rate function from $interval magic variable to __rate_interval. It has been added in Grafana 7.2 for that exact purpose. Signed-off-by: Daniel Mellado <dmellado@redhat.com>
auto-merge was automatically disabled
January 19, 2023 10:10
Head branch was pushed to by a user without write access
danielmellado
dismissed stale reviews from squat and douglascamata
via
fb815ee
danielmellado
force-pushed
the
change_to_rate_interval
branch
from
1c1511b
to
fb815ee
Compare
|
@squat mind re-approving this? I had to rebase due to bad CI, thanks! cc @saswatamcode ;) |
squat
approved these changes
Jan 19, 2023
sshantel
pushed a commit
to sshantel/thanos
that referenced
this pull request
Jan 28, 2023
This PR changes the Thanos mixin dashboard widgets that are using the rate function from $interval magic variable to __rate_interval. It has been added in Grafana 7.2 for that exact purpose. Signed-off-by: Daniel Mellado <dmellado@redhat.com> Signed-off-by: Daniel Mellado <dmellado@redhat.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
This PR changes the Thanos mixin dashboard widgets that are using the rate function from $interval magic variable to __rate_interval. It has been added in Grafana 7.2 for that exact purpose. Signed-off-by: Daniel Mellado <dmellado@redhat.com> Signed-off-by: Daniel Mellado <dmellado@redhat.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
This PR changes the Thanos mixin dashboard widgets that are using the rate function from $interval magic variable to __rate_interval. It has been added in Grafana 7.2 for that exact purpose. Signed-off-by: Daniel Mellado <dmellado@redhat.com> Signed-off-by: Daniel Mellado <dmellado@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Thanos mixin dashboard widgets that are using
the rate function from $interval magic variable to __rate_interval.
It has been added in Grafana 7.2 for that exact purpose.
Signed-off-by: Daniel Mellado dmellado@redhat.com