Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support native histograms in store-gateway #6056

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

fpetkovski
Copy link
Contributor

@fpetkovski fpetkovski commented Jan 19, 2023

This commit adds support for retrieving native histogram chunks
in Store Gateway.

  • I added CHANGELOG entry for this change.
  • Change is not relevant to the end user.

Changes

Verification

@fpetkovski fpetkovski force-pushed the store-gw-histograms branch 2 times, most recently from 2f858cb to 1f8f571 Compare January 19, 2023 09:36
@fpetkovski
Copy link
Contributor Author

This is currently blocked by #6032.

@fpetkovski fpetkovski marked this pull request as ready for review January 27, 2023 09:25
This commit adds support for retrieving native histogram chunks
in Store Gateway.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
@fpetkovski
Copy link
Contributor Author

Should be ready for review now.

pkg/store/bucket.go Outdated Show resolved Hide resolved
Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Copy link
Member

@GiedriusS GiedriusS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙇, just some CI failures left

@fpetkovski
Copy link
Contributor Author

Hm I am not sure if the sonatype-lift comments make sense. Two of them say it cannot import github.com/prometheus/prometheus/model/histogram which I don't fully understand, and the third one is related to a crypto function in test code.

@GiedriusS GiedriusS merged commit 5e3ecf6 into thanos-io:main Feb 21, 2023
@rabenhorst rabenhorst mentioned this pull request Feb 27, 2023
7 tasks
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
* Support native histograms in store-gateway

This commit adds support for retrieving native histogram chunks
in Store Gateway.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Fix tests

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Revert test changes

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

---------

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
ngraham20 pushed a commit to ngraham20/thanos that referenced this pull request Apr 17, 2023
* Support native histograms in store-gateway

This commit adds support for retrieving native histogram chunks
in Store Gateway.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Fix tests

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

* Revert test changes

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>

---------

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants