sidecar: implement without replica labels capability #6127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiedriusS
commented
Feb 15, 2023
GiedriusS
force-pushed
the
implement_without_replica_labels_capability_sidecar
branch
2 times, most recently
from
5ac922b to
6f8f6dd
Compare
fpetkovski
reviewed
Feb 20, 2023
pkg/store/prometheus.go
Outdated
| extLsetToRemove := map[string]struct{}{} | ||
| for _, lbl := range r.WithoutReplicaLabels { | ||
| extLsetToRemove[lbl] = struct{}{} | ||
| } |
There was a problem hiding this comment.
I know this is still draft, but should we remove the labels from the existing extLset here? This way everything else will keep working and we don't need to do rmLabel everywhere else.
Maybe we should even move this chunk to line 176 to make sure we strip replica labels when skipChunks is true.
There was a problem hiding this comment.
@fpetkovski you are correct, I had to move this chunk a bit to cover shipChunks case. I actually noticed that Prometheus already sends labels with external labels in them so I'm not sure why we were always calling labels.Extend. I have removed that.
There was a problem hiding this comment.
Makes sense. The good thing with this is that we don't need to copy labels.
GiedriusS
force-pushed
the
implement_without_replica_labels_capability_sidecar
branch
from
6f8f6dd to
11efe5c
Compare
GiedriusS
force-pushed
the
implement_without_replica_labels_capability_sidecar
branch
2 times, most recently
from
b4f149c to
27ffd8c
Compare
Implement the new without replica labels capability in Sidecar to have more efficient querying. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
implement_without_replica_labels_capability_sidecar
branch
from
27ffd8c to
dad8ea4
Compare
GiedriusS
deleted the
implement_without_replica_labels_capability_sidecar
branch
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Implement the new without replica labels capability in Sidecar to have more efficient querying. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
Implement the new without replica labels capability in Sidecar to have more efficient querying. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the new without replica labels capability in Sidecar to have more efficient querying.