Fix error handling in gRPC query API #6139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpetkovski
force-pushed
the
grpc-api-error-handling
branch
from
2b24b2e to
b900ae2
Compare
The gRPC query api does not propagate errors from the promql engine to the upstream client. This causes calls against it to fail silently without any error messages. Noticed while testing the distributed query mode. This commit changes the API to propagate errors and warnings as warn messages. The client can then decide whether to abort on each message type, or to proceed with execution and present a partial response message to the user. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
grpc-api-error-handling
branch
from
c34d3d8 to
b6eca0a
Compare
Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
fpetkovski
force-pushed
the
grpc-api-error-handling
branch
from
b6eca0a to
d09af91
Compare
GiedriusS
approved these changes
Feb 20, 2023
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Fix error handling in gRPC query API The gRPC query api does not propagate errors from the promql engine to the upstream client. This causes calls against it to fail silently without any error messages. Noticed while testing the distributed query mode. This commit changes the API to propagate errors and warnings as warn messages. The client can then decide whether to abort on each message type, or to proceed with execution and present a partial response message to the user. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add warning tests and license header Signed-off-by: fpetkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
ngraham20
pushed a commit
to ngraham20/thanos
that referenced
this pull request
Apr 17, 2023
* Fix error handling in gRPC query API The gRPC query api does not propagate errors from the promql engine to the upstream client. This causes calls against it to fail silently without any error messages. Noticed while testing the distributed query mode. This commit changes the API to propagate errors and warnings as warn messages. The client can then decide whether to abort on each message type, or to proceed with execution and present a partial response message to the user. Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> * Add warning tests and license header Signed-off-by: fpetkovski <filip.petkovsky@gmail.com> --------- Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com> Signed-off-by: fpetkovski <filip.petkovsky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gRPC query api does not propagate errors from the promql engine to the upstream client. This causes calls against it to fail silently without any error messages. Noticed while testing the distributed query mode.
This commit changes the API to propagate errors and warnings as warn messages. The client can then decide whether to abort on each message type, or to proceed with execution and present a partial response message to the user.
Changes
Verification
Added unit tests.