Add remoteUser (from http basic auth) and remoteAddr to Thanos slow query logs #6153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When tracking where a suspicious query came from, one often needs to know the remote address or remote user that made the request. Adding these should help with debugging.
Verification
Built locally and ran locally then queried with http client.
Notes
So this is posted slightly early as a proof of concept to see if the basic idea makes sense to the Thanos team.
It seems like
reportQueryStats
is not actually called from anywhere, onlyreportSlowQuery
but I've updated both in the interest of keeping things in sync.