Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy chunk bytes in TSDB store before sending to client #6203

Merged
merged 2 commits into from
Mar 13, 2023
Merged

Copy chunk bytes in TSDB store before sending to client #6203

merged 2 commits into from
Mar 13, 2023

Commits on Mar 10, 2023

  1. Copy chunk bytes in TSDB store before sending to client 

    During head compaction mmaped memory gets released while gRPC is
marshaling bytes from that same memory region. This leads to a fatal
segfault and crashes the receiver. The segfault happens when marshaling
chunks specifically.

This commit modifies the TSDB store server to copy chunk bytes before
sending them to the client. I tried running this for a while and saw
no significant increase in memory usage.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    e65955b View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    681a17a View commit details
    Browse the repository at this point in the history