Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove tenant shipper after prunning #6207

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Remove tenant shipper after prunning #6207

merged 3 commits into from
Mar 16, 2023

Commits on Mar 10, 2023

  1. Remove tenant shipper after prunning 

    We noticed another edge case with tenant prunning where the shipper would
keep syncing blocks even after the tenant TSDB was removed. The reason for this
is because the shipper runs in parallel in a different goroutine and is not
stopped when the TSDB is gone.

This leads to empty shipper files being created on disk once a tenant is pruned,
and the orphaned TSDBs alert from the mixing starts to fire.

This commit modifies the pruning logic to remove all components from a tenant
once eviction conditions have been met.

Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    728cda7 View commit details
    Browse the repository at this point in the history

  2. Add CHANGELOG entry 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    d0141c5 View commit details
    Browse the repository at this point in the history

  3. Run make docs 

    Signed-off-by: Filip Petkovski <filip.petkovsky@gmail.com>
    @fpetkovski
    fpetkovski committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    eed66c3 View commit details
    Browse the repository at this point in the history